-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
www.deviantart.com - Search is not displayed correctly #5895
Comments
Confirmed, "SEARCH" is placeholder of input. Color of input or background might be the root cause. enu.mobileMenu .mobileSearch .searchWrapper input {
border: none;
outline: 0;
background: 0 0;
display: inline-block;
color: transparent;
} Move to needsdiagnosis. |
And the html is: <span class="mobileSearch" style="width: calc(100% + 40px);">
<span class="searchWrapper overhead-main-menu-dropdown-search">
<form method="get" autocomplete="off" id="site-search-form" class="search-form" action="http://www.deviantart.com/browse/all/" data-ga_submit_event="{"category":"Search","action":"Loginbar"}">
<i class="icon-mag"></i>
<a href="" class="icon-nav-close"></a>
<input name="global" value="1" type="hidden">
<input id="search" name="q" placeholder="SEARCH">
</form>
</span>
</span> Yes the color is transparent and it is the cause in Gecko. The why this is not happening in WebKit/Blink is… mistery 🔬 AH! after one hour of searching colors and device-pixel-ratio and so on. It's a lot simpler… and SIGH.
in WebKit and Blink, From left to right Firefox, Safari, Opera: I will open a bug on bugzilla. |
Opened the issue https://bugzilla.mozilla.org/show_bug.cgi?id=1357674 |
And the codepen that I used for testing. |
Followup on this issue, and we really need to contact them. A discussion with @bzbarsky on the issue In the CSS they define the menu.mobileMenu .mobileSearch .searchWrapper input:focus::-webkit-input-placeholder {
opacity:0
}
menu.mobileMenu .mobileSearch .searchWrapper input:focus::-moz-input-placeholder {
opacity:0
}
menu.mobileMenu .mobileSearch .searchWrapper input::-webkit-input-placeholder {
font-family:Calibre-Bold;
font-size:72px;
line-height:72px;
color:rgba(255,255,255,.5)
}
menu.mobileMenu .mobileSearch .searchWrapper input::-moz-input-placeholder {
font-family:Calibre-Bold;
font-size:72px;
color:rgba(255,255,255,.5)
} So the combination of transparent and the error in the selector makes it fail. They use Once I change to the right value, I get: Note that it would be even better if they were just doing menu.mobileMenu .mobileSearch .searchWrapper input:focus::-webkit-input-placeholder {
opacity:0
}
menu.mobileMenu .mobileSearch .searchWrapper input:focus::placeholder {
opacity:0
}
menu.mobileMenu .mobileSearch .searchWrapper input::-webkit-input-placeholder {
font-family:Calibre-Bold;
font-size:72px;
line-height:72px;
color:rgba(255,255,255,.5)
}
menu.mobileMenu .mobileSearch .searchWrapper input::placeholder {
font-family:Calibre-Bold;
font-size:72px;
color:rgba(255,255,255,.5)
} The support is across the board. http://caniuse.com/#feat=css-placeholder and probably add the value for Edge. Or maybe Edge is aliasing the |
I wonder if @metamode or @ArtBIT can put us in contact with people in charge of @DeviantArt CSS for mobile so we can fix the issue that users on Firefox Mobile are hitting. |
Thanks for investigating and practically solving this issue :) TIL about webcompat.com - it's an amazing concept, keep it up! |
Thanks a lot @ArtBIT . Appreciated. |
@karlcow, this seems to be working correctly on my phone now. |
yup this has been fixed. |
URL: www.deviantart.com
Browser / Version: Firefox Mobile Nightly 55.0a1 (2017-04-17)
Operating System: Samsung Galaxy Note 4 (Android 5.0.1)
Problem type: Text is not visible
Steps to Reproduce
Expected Behavior:
Search string and a magnifying glass is displayed.
Actual Behavior:
Only the magnifying glass is displayed.
Notes:
Watchers:
@softvision-oana-arbuzov
@softvision-sergiulogigan
sv; country: us
From webcompat.com with ❤️
The text was updated successfully, but these errors were encountered: