typeerorr with chrome addon installed

[miketaylr]

Uncaught TypeError: Cannot read property 'classList' of null
    at content.js:6

str:

1. install official webcompat reporter addon in chrome
2. visit webcompat.com and look in console

looks like maybe we need to update that selector (possibly for all addons?)

[laghee]

Yeah, weird, I don't get the same error in nightly, beta, or release, but it's definitely not hiding the download link in firefox (or fennec).

DevEd console:

[miketaylr]

We probably just changed the classname of the link and forgot to update the content script here in the addon.

[laghee]

Yep, looks like it needs to be replaced with body-webcompat.

[miketaylr]

That might make the whole site disappear... maybe js-addon-link?

[laghee]

😂 oops. Yeah, I guess that makes more sense. I must have found is-hidden in there and gotten confused.

Is it better practice to drill down to the smallest possible element (e.g., not using the outer js-addon block)?

[miketaylr]

Is it better practice to drill down to the smallest possible element (e.g., not using the outer js-addon block)?

As long as we hide the link that we need to, it probably doesn't matter that much.

[miketaylr]

[mbuotidem]

@miketaylr interested in working on this. Any tips?

[miketaylr]

Cool!

I believe the fix will be to update the selector in content.js, to match the the updated class name on webcompat.com:

<a class="nav-link js-addon-link" href="https://chrome.google.com/webstore/detail/webcompatcom-reporter/ffnnhckjcpbbjlmgfjigknkoffakclol" title="Navigate to Chrome webstore">
            <svg class="icon nav-icon" viewBox="0 0 30 30" role="presentation" aria-hidden="true">
                <use xlink:href="#svg-download2"></use>
            </svg>
            <span class="link-text">Download Chrome Add-on</span>
        </a>

To verify it's working locally, with Chrome, install your local addon, go to webcompat.com, and make sure there's no console errors, and also that the "Download Chrome Add-on" link is hidden.

[miketaylr]

Oh wait... I think @laghee did this.

laghee@5039161

[miketaylr]

We really need to get better at closing out fixed issues. 😓

[miketaylr]

(and publish an update to the chrome store)

[miketaylr]

Arf, not fixed yet. There's a PR.