Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

labels colors don't update correctly #2262

Closed
zoepage opened this issue Mar 19, 2018 · 5 comments
Closed

labels colors don't update correctly #2262

zoepage opened this issue Mar 19, 2018 · 5 comments
Assignees
@miketaylr

Comments

@zoepage
Copy link
Member

zoepage commented Mar 19, 2018

I found 2 issues, I guess related.

  1. When I select labels they are added, but not saved. So they disappear on reload and the old state is been reset.

  2. After selecting the labels, the color disappears (just in Chrome). Here not the right class is applied like e.g. browser-chrome, but a color browser-ededed.

chrome_labels

@miketaylr You have any idea?
@zoepage zoepage mentioned this issue Mar 19, 2018
Closed
@miketaylr
Copy link
Member

Good find @zoepage. Let's see what's up...

@miketaylr miketaylr self-assigned this Mar 20, 2018
@miketaylr
Copy link
Member

When I select labels they are added, but not saved. So they disappear on reload and the old state is been reset.

I can't reproduce this part just yet, but I do see the issue about the wrong label class being added.

@miketaylr
Copy link
Member

(also just noticed the milestone editor says Filter Labels, let's fix that here too).

screen shot 2018-03-20 at 3 59 33 pm

@miketaylr
Copy link
Member

Here's the bug:

https://github.com/webcompat/webcompat.com/blame/refactor/webcompat/templates/issue/issue-labels-sub.jst#L3

@miketaylr miketaylr changed the title labels in Chrome don't update labels colors don't update correctly Mar 20, 2018
@miketaylr miketaylr mentioned this issue Mar 20, 2018
Closed
miketaylr added a commit that referenced this issue Mar 20, 2018
@miketaylr
Issue #2262. Fix some milestone template copypasta.
b8a500a
miketaylr added a commit that referenced this issue Mar 20, 2018
@miketaylr
Issue #2262. label reRender should get remoteName, not color.
4023bf9
miketaylr added a commit that referenced this issue Mar 20, 2018
@miketaylr
Issue #2262. Remove notion of milestones having a color.
977ecf0 
It's not used anymore.
miketaylr added a commit that referenced this issue Mar 21, 2018
@miketaylr
Issue #2262. Remove leftover boilerplate.
6873770
zoepage added a commit that referenced this issue Mar 21, 2018
@zoepage
Merge pull request #2273 from /issues/2262/1
7d4afa8 
Fixes: #2262: Choose correct color for label updates
@zoepage
Copy link
Member Author

zoepage commented Mar 21, 2018

merged #2273

@zoepage zoepage closed this as completed Mar 21, 2018
miketaylr added a commit that referenced this issue Mar 23, 2018
@miketaylr
Issue #2262. Fix some milestone template copypasta.
203e13a
miketaylr added a commit that referenced this issue Mar 23, 2018
@miketaylr
Issue #2262. label reRender should get remoteName, not color.
b731c8d
miketaylr added a commit that referenced this issue Mar 23, 2018
@miketaylr
Issue #2262. Remove notion of milestones having a color.
f69a754 
It's not used anymore.
miketaylr added a commit that referenced this issue Mar 23, 2018
@miketaylr
Issue #2262. Remove leftover boilerplate.
a575a25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @zoepage