Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style to cssfixme service. #848

Closed
karlcow opened this issue Dec 10, 2015 · 6 comments
Closed

Add style to cssfixme service. #848

karlcow opened this issue Dec 10, 2015 · 6 comments

Comments

@karlcow
Copy link
Member

karlcow commented Dec 10, 2015

We're including a tool to fix CSS code, which will go live on https://webcompat.com/tools/cssfixme . The tool was developed in its own repo, which is https://github.com/webcompat/css-fixme/ .

This tool needs some more style/design work. Can the styling be more integrated with the rest of this site?
This task might also involve changing/moving the text and explanations on the page, if you as a designer would like to do so.

Depends on #12
See also #847

@hallvors
Copy link
Contributor

An important part here is the equivalent of this:

pre strong{
    background: yellow;
    color:black;
}

to highlight the style rules the tool adds to the output.

@karlcow
Copy link
Member Author

karlcow commented Dec 18, 2015

It needs a bit of reorg of the text, and better styling.

What it currently looks like as of today.
capture d ecran 2015-12-18 a 12 10 40

@magsout
Copy link
Member

magsout commented Dec 29, 2015

let's add some webcompat style on this tools

@miketaylr
Copy link
Member

👍

miketaylr pushed a commit that referenced this issue Dec 29, 2015
Issue #848 - Add style to cssfixme service
@magsout
Copy link
Member

magsout commented Dec 29, 2015

@hallvors why strong element in your selector ? If i inspect DOM, I can't see any <strong> element

magsout added a commit that referenced this issue Dec 30, 2015
magsout added a commit that referenced this issue Dec 30, 2015
           - removed <pre> which is generated by the script
magsout added a commit that referenced this issue Dec 30, 2015
           - removed <pre> which is generated by the script
hallvors pushed a commit that referenced this issue Dec 31, 2015
miketaylr pushed a commit that referenced this issue Dec 31, 2015
(This fixes a double script include bug)
miketaylr pushed a commit that referenced this issue Dec 31, 2015
Issue #848 - improve layout CSSFixme
@magsout
Copy link
Member

magsout commented Dec 31, 2015

Let's close. Open new issue if we need something more..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants