Fixes #2322 - rename fix to lint:fixin pkg.json
#2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketaylr
approved these changes
Mar 28, 2018
docs/pr-coding-guidelines.md
Outdated
| @@ -159,7 +159,7 @@ In order to avoid errors during a Pull Request, `npm run lint` will be executed | |||
| `npm run lint` checks all relevant JavaScript and CSS files and displays, if something needs to be fixed. | |||
|
|
|||
| If you get an error displayed, there are two ways to fix it. | |||
| 1. You can run `npm run fix` automatically (only for JavaScript), which is great for small issues like missing spaces or lines in various files. | |||
| 1. You can run `npm run lint:fix` automatically (only for JavaScript), which is great for small issues like missing spaces or lines in various files. | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
(also, small typo in the commit message: upadte docs) |
|
r? @miketaylr |
miketaylr
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @miketaylr