Skip to content

Commit

Permalink
magento#38682 - Fix DeployPackage type error
Browse files Browse the repository at this point in the history
  • Loading branch information
Nuranto committed Apr 30, 2024
1 parent 995a05c commit c8adafc
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
10 changes: 7 additions & 3 deletions app/code/Magento/Deploy/Service/DeployPackage.php
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,13 @@ public function deployEmulated(Package $package, array $options, $skipLogging =
try {
$this->processFile($file, $package);
} catch (ContentProcessorException $exception) {
$errorMessage = __('Compilation from source: ')
. $file->getSourcePath()
. PHP_EOL . $exception->getMessage() . PHP_EOL;
$errorMessage = __(
'Compilation from source: %1',
$file->getSourcePath()
. PHP_EOL
. $exception->getMessage()
. PHP_EOL
);
$this->errorsCount++;
$this->logger->critical($errorMessage);
$package->deleteFile($file->getFileId());
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Deploy/i18n/en_US.csv
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"The configuration file has changed. Run app:config:import or setup:upgrade command to synchronize configuration.","The configuration file has changed. Run app:config:import or setup:upgrade command to synchronize configuration."
"Wrong type specified: '%1'","Wrong type specified: '%1'"
"Wrong queue type specified.","Wrong queue type specified."
"Compilation from source: ","Compilation from source: "
"Compilation from source: %1","Compilation from source: %1"
"Wrong deploy strategy type: %1","Wrong deploy strategy type: %1"
"Some error","Some error"
"some message","some message"

0 comments on commit c8adafc

Please sign in to comment.