Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different CPU architectures #65

Closed
sephiroth-j opened this issue Dec 8, 2021 · 4 comments · Fixed by #124
Closed

Support different CPU architectures #65

sephiroth-j opened this issue Dec 8, 2021 · 4 comments · Fixed by #124
Assignees
Milestone

Comments

@sephiroth-j
Copy link
Member

As discussed in webdriverextensions/webdriverextensions-maven-plugin-repository#91

The os.arch / cpu architecture would be good. It would be a new property of the driver object defaulting to "x86" if not set. CPU arch + platform + 64bit = better driver selection.

@ocindev
Copy link

ocindev commented Aug 4, 2022

Hi @sephiroth-j , is there any progress on this topic ? I'd like to help whereever i can to speed up the integration of the Apple Silicon drivers into the webdriveextensions-maven-plugin-repository.

sephiroth-j added a commit that referenced this issue Sep 27, 2022
…OS/CPU architectures such as AARCH64 (aka ARM64)

The "arch" property allows to further distinguish between multiple variants with the same "bit" value.
If omitted, the value will be detected from the current JVM, making it backwards compatible.

fixes #65
sephiroth-j added a commit that referenced this issue Sep 27, 2022
…OS/CPU architectures such as AARCH64 (aka ARM64)

The "arch" property allows to further distinguish between multiple variants with the same "bit" value.
If omitted, the value will be detected from the current JVM, making it backwards compatible.

fixes #65
@sephiroth-j
Copy link
Member Author

I just released a SNAPSHOT of version 3.4.0 which includes support for AARCH64. It uses a special version of the repository file which includes the following

  • edgedriver 105.0.1343.53 for MAC and WINDOWS on ARM64
  • chromedriver 105.0.5195.52 for MAC on ARM64
  • geckodriver 0.31.0 for MAC on ARM64

It is also no problem to use this repo file with the current stable version 3.3.0 of the plugin. The new property is ignored and the plugin finds the 64-bit variant of the driver twice and selects the first one - i.e. the AMD64 variant.

Anyone who wants to test this version must change the version of the plugin in pom.xml to "3.4.0-SNAPSHOT" and add the Sonatype SNAPSHOT repository with url "https://oss.sonatype.org/content/repositories/snapshots/" as follows.

<repositories>
	<repository>
		<id>sonatype snapshots</id>
		<url>https://oss.sonatype.org/content/repositories/snapshots/</url>
	</repository>
</repositories>

sephiroth-j added a commit that referenced this issue Oct 3, 2022
…OS/CPU architectures such as AARCH64 (aka ARM64)

The "arch" property allows to further distinguish between multiple variants with the same "bit" value.
If omitted, the value will be detected from the current JVM, making it backwards compatible.

fixes #65
@ocindev
Copy link

ocindev commented Oct 10, 2022

Hi,
just tested this. Works fine for me. Apple M1 with macOS 12.6

@sephiroth-j
Copy link
Member Author

Thanks, that's good to hear.

@sephiroth-j sephiroth-j linked a pull request Nov 20, 2022 that will close this issue
sephiroth-j added a commit that referenced this issue Nov 20, 2022
…-cpu-architectures

#65 support different cpu architectures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants