Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Change compilers to be loaded before the requires #72

Closed
wants to merge 2 commits into from
Closed

Change compilers to be loaded before the requires #72

wants to merge 2 commits into from

Conversation

snoozbuster
Copy link

This addresses #71.

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test?

@snoozbuster
Copy link
Author

I can but I'm not super sure what the test would look like. (also, I don't think the test that failed is related to these changes).

@snoozbuster
Copy link
Author

snoozbuster commented Jul 14, 2017

@christian-bromann added the test and it looks like all checks passed this time, can you review? (also, the test I modified doesn't pass on windows at all because the slashes go the other way. not sure how important it is to you to fix that)

@snoozbuster
Copy link
Author

@christian-bromann any movement here?

@christian-bromann
Copy link
Contributor

Couldn't merge the PR due to the line break changes. But I applied all actual changes to master. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants