Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiremote is broken in 5.4.13 #3492

Closed
xlenz opened this issue Feb 4, 2019 · 2 comments · Fixed by #3496
Closed

multiremote is broken in 5.4.13 #3492

xlenz opened this issue Feb 4, 2019 · 2 comments · Fixed by #3496

Comments

@xlenz
Copy link

xlenz commented Feb 4, 2019 •
edited

Environment (please complete the following information):

  • WebdriverIO version: 5.4.13

Config of WebdriverIO

    capabilities: {
        myChromeBrowser: {
            capabilities: {
                browserName: 'chrome'
            }
        },
        myFirefoxBrowser: {
            capabilities: {
                browserName: 'firefox'
            }
        }
    }

Describe the bug
multiremote stopped working in 5.4.13 due to bug in isRDC

To Reproduce
launch multiremote session

Expected behavior
multiremote should work

Log

@wdio/config/build/lib/ConfigParser.js:84
      throw e;
      ^

TypeError: this._capabilities.some is not a function
    at ConfigParser.addConfigFile (/Users/mygr/sources/e2e/node_modules/@wdio/config/build/lib/ConfigParser.js:75:40)

Additional context
#3468
https://github.com/webdriverio/webdriverio/pull/3468/files#r253472523
@wswebcreation
Copy link
Member

@xlenz

Hmm, I see, for multiremote you need to provide an object instead of an array according to the docs. I'll try to make a fix for it

@wswebcreation wswebcreation mentioned this issue Feb 4, 2019
Merged
6 tasks
@christian-bromann
Copy link
Member

we need a multiremote smoke test to prevent this from happening again

christian-bromann pushed a commit that referenced this issue Feb 5, 2019
@wswebcreation @christian-bromann
Fix/3492 fix multi remote (#3496)
c14e5e1 
## Proposed changes

This PR fixes #3492. The new added line didn't look at multiremote support which should be an object instead of an array

## Types of changes

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist


- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)

## Further comments

@webdriverio/technical-committee, I was wondering why for multiremote we need to haven an object, why aren't we providing an array with an object. This makes it confusing
yamkay pushed a commit to MoveInc/webdriverio that referenced this issue Jun 13, 2019
@wswebcreation
Fix/3492 fix multi remote (webdriverio#3496)
a4dac9d 
## Proposed changes

This PR fixes webdriverio#3492. The new added line didn't look at multiremote support which should be an object instead of an array

## Types of changes

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist


- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)

## Further comments

@webdriverio/technical-committee, I was wondering why for multiremote we need to haven an object, why aren't we providing an array with an object. This makes it confusing
yamkay pushed a commit to MoveInc/webdriverio that referenced this issue Sep 4, 2019
@wswebcreation @christian-bromann
Fix/3492 fix multi remote (webdriverio#3496)
a48d535 
## Proposed changes

This PR fixes webdriverio#3492. The new added line didn't look at multiremote support which should be an object instead of an array

## Types of changes

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist


- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)

## Further comments

@webdriverio/technical-committee, I was wondering why for multiremote we need to haven an object, why aren't we providing an array with an object. This makes it confusing
kimarakov added a commit to kimarakov/webdriver that referenced this issue Dec 29, 2021
@kimarakov
Fix/3492 fix multi remote (#3496)
2f0f144 
## Proposed changes

This PR fixes webdriverio/webdriverio#3492. The new added line didn't look at multiremote support which should be an object instead of an array

## Types of changes

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist


- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)

## Further comments

@webdriverio/technical-committee, I was wondering why for multiremote we need to haven an object, why aren't we providing an array with an object. This makes it confusing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/3492 fix multi remote webdriverio/webdriverio
3 participants
@christian-bromann @xlenz @wswebcreation