Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Jasmine sessions for BrowserStack Test Observability (v8) #10421

Merged
merged 7 commits into from May 22, 2023
Merged

Support for Jasmine sessions for BrowserStack Test Observability (v8) #10421

merged 7 commits into from May 22, 2023

Conversation

sriteja777
Copy link
Contributor

Proposed changes

  • Add support for Jasmine sessions to be captured by BrowserStack Test Observability
  • Add a performance tester utility for measuring performance of Observability related code.

Related v7 PR: #10173

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@sriteja777
Copy link
Contributor Author

@christian-bromann Please review this PR whenever you are free. AlsorRelated v7 PR too

christian-bromann
christian-bromann approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label May 22, 2023
@christian-bromann christian-bromann merged commit f6238d7 into webdriverio:main May 22, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sriteja777 @christian-bromann