Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(webdriverio): fix aria selector strategy #11586

Merged
merged 11 commits into from
Nov 9, 2023
Merged

(webdriverio): fix aria selector strategy #11586

merged 11 commits into from
Nov 9, 2023

Conversation

erwinheitzman
Copy link
Member

@erwinheitzman erwinheitzman commented Nov 3, 2023 •
edited

Proposed changes

Fixes #11585 and #8826

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@erwinheitzman erwinheitzman added the PR: Bug Fix 🐛 PRs that contain bug fixes label Nov 9, 2023
@erwinheitzman erwinheitzman marked this pull request as ready for review November 9, 2023 10:33
@erwinheitzman erwinheitzman self-assigned this Nov 9, 2023
christian-bromann
christian-bromann approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, some real xPath wizardry 🪄

wizardry

👍

@christian-bromann christian-bromann merged commit ea50fe1 into webdriverio:main Nov 9, 2023
8 checks passed
@christian-bromann christian-bromann mentioned this pull request Nov 9, 2023
Closed
3 tasks
@erwinheitzman erwinheitzman deleted the fix-aria-selector-strategy branch November 9, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

@erwinheitzman erwinheitzman

Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: aria selector strategy does not always work
2 participants
@erwinheitzman @christian-bromann