Adding back cucumber before & after Hooks support #11628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This is awesome! Do you think we could add a smoke tests that verifies that these hooks are executed? Maybe create a new cucumber config for it that has these hooks defined, then write something to a file and verify the file after the wdio testrunner execution in smoke.test.js. With customService we already have similar test that ensure that services run all hooks properly.
|
I am working on resolving some pending PRs and will go ahead and merge this and will add the missing smoke tests myself. |
|
In case you are interested: 37df96b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #11491
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers