Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(webdriver): retry on post requests #11667

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

christian-bromann
Copy link
Member

Proposed changes

We have experienced a lot of errors in our test pipeline from our e2e Windows tests where establishing an Edge session failed due to ECONNREFUSED. This could be caused by Edgedriver not being ready for requests at the point of calling newSession. I looked into our retry mechanism which should catch this and turns out we don't do retries on POST requests since got doesn't do this by default.

I updated the methods option for retries to include post requests since they are used a lot in the WebDriver protocol.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Nov 13, 2023
@christian-bromann christian-bromann merged commit 28f02d7 into main Nov 14, 2023
8 checks passed
@christian-bromann christian-bromann deleted the cb/retry-posts-requests branch November 14, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant