Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(internal): fix usage of intialise wording in variables, comments and elsewhere #11672

Merged
merged 2 commits into from Nov 15, 2023

Conversation

christian-bromann
Copy link
Member

Proposed changes

We have been using initialise across the code base. initialise and initialize are both English terms. Initialize is predominantly used in 🇺🇸 American (US) English ( en-US ) while initialise is predominantly used in 🇬🇧 British English (used in UK/AU/NZ) ( en-GB ). In the United States, there is a preference for "initialize" over "initialise" (99 to 1).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Internal 🏠 PRs that contain changes internals label Nov 15, 2023
@christian-bromann christian-bromann changed the title (internal): fix usage of wrong wording in variables, comments and elsewhere (internal): fix usage of intialise wording in variables, comments and elsewhere Nov 15, 2023
@christian-bromann christian-bromann merged commit 0ccef16 into main Nov 15, 2023
7 of 8 checks passed
@christian-bromann christian-bromann deleted the cb/initialise-vs-initialize branch November 15, 2023 06:10
@christian-bromann christian-bromann restored the cb/initialise-vs-initialize branch November 15, 2023 06:10
@christian-bromann christian-bromann deleted the cb/initialise-vs-initialize branch November 15, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠 PRs that contain changes internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant