Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deleted BidiHandler and browser commands from Element type #11679

Merged
merged 2 commits into from Nov 18, 2023
Merged

deleted BidiHandler and browser commands from Element type #11679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b71e367
deleted BidiHandler and browser commands from Element type
udarrr Nov 17, 2023
5947b3e
changed condition in fetchElementByJSFunction
udarrr Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/webdriverio/src/types.ts
View file
Open in desktop
Expand Up @@ -286,7 +286,7 @@ export interface ElementBase extends InstanceBase, ElementReference, CustomInsta
/**
* @deprecated use `WebdriverIO.Element` instead
*/
export interface Element extends ElementBase, BidiHandler, ProtocolCommands, Omit<BrowserCommandsType, keyof ElementCommandsType>, ElementCommandsType {}
export interface Element extends ElementBase, ProtocolCommands, ElementCommandsType {}

interface MultiRemoteBase extends Omit<InstanceBase, 'sessionId'>, CustomInstanceCommands<WebdriverIO.MultiRemoteBrowser> {
/**
Expand Down
2 changes: 1 addition & 1 deletion packages/webdriverio/src/utils/index.ts
View file
Open in desktop
Expand Up @@ -198,7 +198,7 @@ function fetchElementByJSFunction (
scope: WebdriverIO.Browser | WebdriverIO.Element,
referenceId?: string
): Promise<ElementReference | ElementReference[]> {
if (!(scope as WebdriverIO.Element).elementId) {
if (!('elementId' in scope)) {
return scope.execute(selector as any, referenceId)
}
/**
Expand Down