New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix filtering test specs by part of their name using CLI --spec arg #11771
Fix filtering test specs by part of their name using CLI --spec arg #11771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, awesome work!
Could you add some tests to verify the behavior? 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a stab at it. I made some comments to hopefully simplify the code. Let me know if you have any questions.
@christian-bromann @erwinheitzman Thank you for your comments! Upon further consideration, I revisited the current approach and made adjustments. From my analysis, the main issues stemmed from two points:
I fixed issues above and now the --spec option works correctly. I have also included smoke tests to verify this functionality. Please check my PR one more time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some feedback
19697d0
to
c9a3908
Compare
@christian-bromann @erwinheitzman |
@tech-dm-klymenko thanks! It seems that there are some issues in CI 🤔 |
@christian-bromann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to fix the test, it seems like we are very close
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is another issue at hand here which is outside of the scope of your PR, I made a suggestion how to work around it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot! 👍
Fantastic first contribution 🎉 |
Thank you very much for your appreciation! 😊 |
Proposed changes
Issue: #9495
A bugfix for this functionality has been released:
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers