New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #10853 - Show test logs in terminal grouped by Worker Instance #11871
Fix for #10853 - Show test logs in terminal grouped by Worker Instance #11871
Conversation
I feel like this should be a choice (an option) instead as it changes the reporting output that people expect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, the behavior whether:
- logs are printed in real time unordered or
- logs are printed in order at the end
should be something configurable or we say if there is only 1 instance running we print it immediately, with more than 1 instance running in parallel we print them ordered at the end. But even then I can see people wanting to see the logs in real time.
Suggestions?
I remember on Wdio v4-5 we had logs that were printed in real time. Then someone made a PR to print the logs grouped by worker when the worker finished. Now we seem to be back to wdio v4-5 log printing version. Will we change this every few years?)) I agree with erwinheitzman that there should be an option for these two behaviours. |
I may be wrong about the versions and behaviour of log printing, but I seem to recall that this is not the first time we have changed it. |
I've added new option |
Documentation has been updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor edits and suggestions.
website/i18n/ta/docusaurus-plugin-content-docs/current/Configuration.md
Outdated
Show resolved
Hide resolved
website/i18n/ru/docusaurus-plugin-content-docs/current/Configuration.md
Outdated
Show resolved
Hide resolved
website/i18n/zh/docusaurus-plugin-content-docs/current/Configuration.md
Outdated
Show resolved
Hide resolved
website/i18n/ar/docusaurus-plugin-content-docs/current/Configuration.md
Outdated
Show resolved
Hide resolved
@christian-bromann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Issue: #10853
Proposed changes
Currently logs are generated and promptly displayed on the terminal during a test run. However, this poses a challenge during parallel test execution, as the test logs from different workers become intermingled, causing inconvenience in identification.
The proposed enhancements fix this issue by organizing test logs in the terminal based on the respective workers, thereby streamlining the process of distinguishing and interpreting the output from different workers.
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers