Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Hide exception logs for logs upload in test observability #11903

Merged
merged 2 commits into from
Dec 21, 2023
Merged

refactor: Hide exception logs for logs upload in test observability #11903

merged 2 commits into from
Dec 21, 2023

Conversation

sauravdas1997
Copy link
Contributor

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@karanshah-browserstack
Copy link

@christian-bromann Did you get a chance to review this? Looks good from our side.

christian-bromann
christian-bromann approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Dec 21, 2023
@christian-bromann christian-bromann merged commit 3297741 into webdriverio:main Dec 21, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

@kamal-kaur04 kamal-kaur04 kamal-kaur04 approved these changes

@karanshah-browserstack karanshah-browserstack karanshah-browserstack approved these changes

Assignees
No one assigned
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sauravdas1997 @karanshah-browserstack @christian-bromann @kamal-kaur04