Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browserstack-service] Fix integrations data #12034

Merged
merged 2 commits into from Jan 17, 2024

Conversation

sriteja777
Copy link
Contributor

@sriteja777 sriteja777 commented Jan 17, 2024

Proposed changes

  • Add caps params to Insights handler

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@sriteja777
Copy link
Contributor Author

Hey @christian-bromann, the tests are failing on this PR, but seems unrelated to the changes in this PR (also tried rerunning). Can you please check once?

@karanshah-browserstack
Copy link

Hello @christian-bromann,
Due to a merge conflict problem, we accidentally broke a feature for one of the BrowserStack products in the most recent version of wdio v8.28.0. We are doing an internal root cause analysis for the problem, as well as determining how to prevent it in the future.
For the time being, we need your assistance in reviewing from the wdio perspective and releasing a bug fix for the wdio-browserstack service.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 17, 2024
@christian-bromann christian-bromann merged commit 394092c into webdriverio:main Jan 17, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants