Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not add pause for iOS keys #12040

Merged
merged 2 commits into from Jan 17, 2024
Merged

Conversation

wswebcreation
Copy link
Member

Proposed changes

This PR fixes the keys bug for iOS

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann
Copy link
Member

Moving ahead and merge. The test fail for a different reason that we are working on fixing.

@christian-bromann christian-bromann merged commit 2856801 into main Jan 17, 2024
3 of 8 checks passed
@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Jan 17, 2024
@christian-bromann christian-bromann deleted the fix-issue-12039-ios-keys branch January 17, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants