-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 11996: Not skip duplicate steps #12044
Conversation
@perillai thanks for the PR, seems like a unit test snapsot makes the test fail, can you verify and update the snapshot? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we revert the formatting changes first, it makes it hard to review actual changes.
[loremipsum 50 Windows 10 #0-0] red ✖ loo | ||
[loremipsum 50 Windows 10 #0-0] green ✓ loo (1 retries) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not desired. If a test gets retried the failing tests before should not be displayed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The retries come from specFileRetries in wdio config. Though it is initialised as 0 in test:start, while test ends, it is not updated but rather updated 'retries' is passed to onRunnerEnd which is not updating the retries in hooksAndTests. I ran with old original code and still (1 retries) is not getting printed. I tried with both specFileRetries and retry under cucumberOpts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👌 LGTM 👍
Hey perillai 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Proposed changes
//: Fix for the issue 11996
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers