Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 11996: Not skip duplicate steps #12044

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Conversation

perillai
Copy link
Contributor

@perillai perillai commented Jan 18, 2024

Proposed changes

//: Fix for the issue 11996

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann
Copy link
Member

@perillai thanks for the PR, seems like a unit test snapsot makes the test fail, can you verify and update the snapshot?

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert the formatting changes first, it makes it hard to review actual changes.

Comment on lines 160 to 161
[loremipsum 50 Windows 10 #0-0] red ✖ loo
[loremipsum 50 Windows 10 #0-0] green ✓ loo (1 retries)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not desired. If a test gets retried the failing tests before should not be displayed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The retries come from specFileRetries in wdio config. Though it is initialised as 0 in test:start, while test ends, it is not updated but rather updated 'retries' is passed to onRunnerEnd which is not updating the retries in hooksAndTests. I ran with old original code and still (1 retries) is not getting printed. I tried with both specFileRetries and retry under cucumberOpts.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌 LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 29, 2024
@christian-bromann christian-bromann merged commit 165d109 into webdriverio:main Jan 29, 2024
9 checks passed
@wdio-bot
Copy link
Contributor

Hey perillai 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.
We've sent you an email with further instructions on how to claim your expenses from our development fund. Please
make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io
or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expensable $50 💸 PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants