Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(devtools): #12072

Merged
merged 11 commits into from Jan 24, 2024
Merged

chore(devtools): #12072

merged 11 commits into from Jan 24, 2024

Conversation

gromanas
Copy link
Contributor

  • Update website for AutomationProtocols.md and devtools/README.md

Contributes to: #11860

Signed-off-by: Georgios Romanas gromanas@gmail.com

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@gromanas
chore(devtools):
2a34257 
- Update website for AutomationProtocols.md and devtools/README.md

Contributes to: webdriverio#11860

Signed-off-by: Georgios Romanas gromanas@gmail.com
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 23, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

christian-bromann
christian-bromann reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a alternative wording, let's apply it for the other example as well. Also mind adding a deprecation warning to the automationProtocol option in the docs and in the TypeScript interface?

website/docs/AutomationProtocols.md Outdated Show resolved Hide resolved
website/docs/AutomationProtocols.md Outdated Show resolved Hide resolved
gromanas and others added 5 commits January 24, 2024 11:11
@gromanas @christian-bromann
Update website/docs/AutomationProtocols.md
95625bf 
Co-authored-by: Christian Bromann <git@bromann.dev>
@gromanas @christian-bromann
Update website/docs/AutomationProtocols.md
a6615d3 
Co-authored-by: Christian Bromann <git@bromann.dev>
@gromanas
chore(devtools):
7230bbf 
- Update website for AutomationProtocols.md, Config
and Options.ts with a deprecation warning

Contributes to: webdriverio#11860

Signed-off-by: Georgios Romanas gromanas@gmail.com
@gromanas
chore(devtools):
7e17701 
- Fix typo on Options.ts

Contributes to: webdriverio#11860

Signed-off-by: Georgios Romanas gromanas@gmail.com
@gromanas
chore(devtools):
61b9f52 
- Fix text on packages/devtools/README.md

Contributes to: webdriverio#11860

Signed-off-by: Georgios Romanas gromanas@gmail.com
christian-bromann
christian-bromann reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment

packages/wdio-types/src/Options.ts Outdated Show resolved Hide resolved
gromanas and others added 2 commits January 24, 2024 22:56
@gromanas
chore(devtools):
ef47f5d 
- Change text as per comment on Options.md

Contributes to: webdriverio#11860

Signed-off-by: Georgios Romanas gromanas@gmail.com
@gromanas
Merge branch 'main' into devtools-deprecation-warning
847a721
christian-bromann
christian-bromann approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 👍

website/docs/AutomationProtocols.md Outdated Show resolved Hide resolved
@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Jan 24, 2024
@christian-bromann christian-bromann merged commit c944501 into webdriverio:main Jan 24, 2024
7 of 8 checks passed
@wdio-bot
Copy link
Contributor

Hey gromanas 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.
We've sent you an email with further instructions on how to claim your expenses from our development fund. Please
make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io
or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
Expensable $25 💸 PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gromanas @wdio-bot @christian-bromann