Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add free text search to '--exclude' param #12077

Conversation

tech-dm-klymenko
Copy link
Contributor

@tech-dm-klymenko tech-dm-klymenko commented Jan 23, 2024

Feature for #8210

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Jan 23, 2024
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset looks good 👍 do you think we can add some smoke tests? We should already have some for applying keyword spec params.

Thanks a lot!

packages/wdio-config/src/node/ConfigParser.ts Outdated Show resolved Hide resolved
packages/wdio-config/src/node/ConfigParser.ts Outdated Show resolved Hide resolved
packages/wdio-config/src/node/ConfigParser.ts Outdated Show resolved Hide resolved
@tech-dm-klymenko
Copy link
Contributor Author

@christian-bromann
Sure! I will cover this functionality with smoke tests

@tech-dm-klymenko
Copy link
Contributor Author

@christian-bromann
I have added smoke tests and updated documentation accordingly.
Please review

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optimization but otherwise LGTM 👍

packages/wdio-config/src/node/ConfigParser.ts Show resolved Hide resolved
@christian-bromann christian-bromann merged commit e8aae21 into webdriverio:main Jan 30, 2024
8 checks passed
@wdio-bot
Copy link
Contributor

Hey tech-dm-klymenko 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.
We've sent you an email with further instructions on how to claim your expenses from our development fund. Please
make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io
or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants