-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add free text search to '--exclude' param #12077
Feat: Add free text search to '--exclude' param #12077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changeset looks good 👍 do you think we can add some smoke tests? We should already have some for applying keyword spec params.
Thanks a lot!
@christian-bromann |
@christian-bromann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One optimization but otherwise LGTM 👍
Hey tech-dm-klymenko 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Feature for #8210
Proposed changes
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers