Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ua-parser-js for ReDoS #12127

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

smarkows
Copy link
Contributor

Proposed changes

Update a npm package that is getting flagged as a security vulnerability: https://security.snyk.io/package/npm/ua-parser-js

Types of changes

  • Security Vulnerability
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

The latest version of ua-parser-js should fix the vulnerability https://security.snyk.io/package/npm/ua-parser-js and not have to change the code at all.

Reviewers: @webdriverio/project-committers

Copy link

linux-foundation-easycla bot commented Jan 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: smarkows / name: Simon Markowski (a2b327c)

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Jan 29, 2024
@christian-bromann
Copy link
Member

Just as a note: WebdriverIO users have always downloaded the latest version of that package and never been vulnerable to this.

@christian-bromann christian-bromann merged commit 672d688 into webdriverio:main Jan 29, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants