Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bug#12134 adding a step to clean the buffer after first log. #12137

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix Bug#12134 adding a step to clean the buffer after first log. #12137

merged 1 commit into from
Jan 31, 2024

Conversation

lararojasmr
Copy link
Contributor

@lararojasmr lararojasmr commented Jan 31, 2024 •
edited

Proposed changes

Related to Bug #12134

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/project-committers

@lararojasmr
Fix Bug#12134 adding a step to clean the buffer after first log.
c802d2d 
Signed-off-by: Lara, Manuel <lararojas.mr@gmail.com>
@lararojasmr
Copy link
Contributor Author

@christian-bromann @picakia here the fix. Thanks for reporting.

christian-bromann
christian-bromann approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 31, 2024
@christian-bromann
Copy link
Member

Related to Bug #12094

I don't think this patch fixes #12094 or am I missing something?

@christian-bromann christian-bromann merged commit e5d8e9b into webdriverio:main Jan 31, 2024
11 checks passed
@lararojasmr
Copy link
Contributor Author

Related to Bug #12094

I don't think this patch fixes #12094 or am I missing something?

You got right, I've edited the description. Thanks!

@picakia
Copy link

picakia commented Jan 31, 2024 •
edited

Thanks for this, I'm waiting for my team to update to the new release for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lararojasmr @christian-bromann @picakia