Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Downloads Best Practices #12186

Conversation

M-Hammad-Faisal
Copy link
Contributor

Proposed changes

[📖 Docs]: document how to set download behavior across browser #12105

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

website/docs/BestPractices.md Outdated Show resolved Hide resolved
website/docs/BestPractices.md Outdated Show resolved Hide resolved
website/docs/best-practices/FileDownloads.md Outdated Show resolved Hide resolved
website/docs/best-practices/FileDownloads.md Outdated Show resolved Hide resolved
website/docs/best-practices/FileDownloads.md Outdated Show resolved Hide resolved
website/docs/best-practices/FileDownloads.md Outdated Show resolved Hide resolved
website/docs/best-practices/FileDownloads.md Outdated Show resolved Hide resolved
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job 🎉 one last thing: we want to use the created example recipe and re-use it in our docs. This ensures we have tested code examples in our project and was the reason we created this in the first place. Mind updating that?

website/docs/best-practices/FileDownloads.md Outdated Show resolved Hide resolved
website/docs/best-practices/FileDownloads.md Outdated Show resolved Hide resolved
website/docs/best-practices/FileDownloads.md Outdated Show resolved Hide resolved
@M-Hammad-Faisal
Copy link
Contributor Author

@christian-bromann I have added the full reference of example recipe after the caps.

Screenshot 2024-02-07 at 11 43 13 AM

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Awesome work!

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Feb 7, 2024
@christian-bromann christian-bromann merged commit 73f3918 into webdriverio:main Feb 7, 2024
11 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Feb 7, 2024

Hey M-Hammad-Faisal 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.
We've sent you an email with further instructions on how to claim your expenses from our development fund. Please
make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io
or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@M-Hammad-Faisal M-Hammad-Faisal deleted the docs-how-to-set-download-behavior-across-browser branch February 9, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expensable $25 💸 PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants