Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for chromedriver domain name change #12305

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

paymand
Copy link
Contributor

@paymand paymand commented Feb 17, 2024

Proposed changes

Workaround for chromedriver domain name change.
Fixes #12251 for v8.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Feb 17, 2024
@christian-bromann christian-bromann merged commit ecaced3 into webdriverio:v8 Feb 17, 2024
4 of 9 checks passed
@wdio-bot
Copy link
Contributor

Hey paymand 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@Abel0916
Copy link

Thanks for the quick fixing. It looks like there is no new V8 version published to include this fixing. @christian-bromann Will you publish a new version? Thanks.

@christian-bromann
Copy link
Member

Yes, eventually later today or tomorrow latest.

@SinghMegha27
Copy link

Is this a workaround for this error error Downloading Chromedriver v121.0.6167.185
2024-02-18T14:50:45.738Z WARN webdriver: Chromedriver v121.0.6167.185 don't exist, trying to find known good version.. ?

@christian-bromann
Copy link
Member

@SinghMegha27 this is related to a different issue which WebdriverIO has an internal workaround for, it should still be able to find the right version for you.

nmattia added a commit to dfinity/internet-identity that referenced this pull request Feb 22, 2024
This bumps to the latest version of webdriverio which includes support
for new "Chrome for Testsing" URLs: webdriverio/webdriverio#12305

This is needed for our CI jobs to download "Chrome for Testing", used in
e2e tests.
nmattia added a commit to dfinity/internet-identity that referenced this pull request Feb 22, 2024
Bump webdriverio

This bumps to the latest version of webdriverio which includes support
for new "Chrome for Testsing" URLs: webdriverio/webdriverio#12305

This is needed for our CI jobs to download "Chrome for Testing", used in
e2e tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expensable $50 💸 PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants