Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to click and moveTo outside the given element #12377

Conversation

jemishgopani
Copy link
Contributor

Proposed changes

issue #12190

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

  • I'll raise PR to v8 once this PR is merged.

Reviewers: @webdriverio/project-committers

@erwinheitzman
Copy link
Member

Hi @jemishgopani let's not introduce a flag but instead change the errors to info logs as was suggested in the issue you mentioned instead.

@jemishgopani
Copy link
Contributor Author

Hi @jemishgopani let's not introduce a flag but instead change the errors to info logs as was suggested in the issue you mentioned instead.
Changed to info logs

Screenshot 2024-02-28 at 2 40 28 PM

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a stab at this, added some comments.

packages/webdriverio/src/commands/element/click.ts Outdated Show resolved Hide resolved
packages/webdriverio/src/commands/element/moveTo.ts Outdated Show resolved Hide resolved
packages/webdriverio/src/commands/element/click.ts Outdated Show resolved Hide resolved
@jemishgopani
Copy link
Contributor Author

Hi @christian-bromann
Addressed your comments can you please take a look again?

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@erwinheitzman what do you think?

@erwinheitzman
Copy link
Member

LGTM 👍

@erwinheitzman
Copy link
Member

erwinheitzman commented Feb 29, 2024

One thing to note is that I would like to have this in v8 as I am also updating the click command. @jemishgopani would you mind creating a backport for v8?

You can do that by using git cherry-pick like so:

  1. grab the commit hashes from your commit (you can use git log in your branch or you can copy them from this PR)
  2. follow https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/configuring-a-remote-repository-for-a-fork to update your repository with the upstream
  3. then run git fetch upstream followed by git checkout v8 and git checkout -b backport/<branchname>
  4. lastly run git cherry-pick <commit hash> for each commit you did, start with the oldest and end with the latest
  5. push the changes and create a new PR to merge with v8

@jemishgopani
Copy link
Contributor Author

One thing to note is that I would like to have this in v8 as I am also updating the click command. @jemishgopani would you mind creating a backport for v8?

You can do that by using git cherry-pick like so:

  1. grab the commit hashes from your commit (you can use git log in your branch or you can copy them from this PR)
  2. follow https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/configuring-a-remote-repository-for-a-fork to update your repository with the upstream
  3. then run git fetch upstream followed by git checkout v8 and git checkout -b backport/<branchname>
  4. lastly run git cherry-pick <commit hash> for each commit you did, start with the oldest and end with the latest
  5. push the changes and create a new PR to merge with v8

Already merged #12383

@christian-bromann christian-bromann merged commit 1346d9b into webdriverio:main Feb 29, 2024
3 of 8 checks passed
@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Feb 29, 2024
@erwinheitzman
Copy link
Member

Awesome! Well done and thank you for the contributoon 👍

@wdio-bot
Copy link
Contributor

Hey jemishgopani 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expensable $25 💸 PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants