New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to click and moveTo outside the given element #12377
Add ability to click and moveTo outside the given element #12377
Conversation
Hi @jemishgopani let's not introduce a flag but instead change the errors to info logs as was suggested in the issue you mentioned instead. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a stab at this, added some comments.
Hi @christian-bromann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@erwinheitzman what do you think?
LGTM 👍 |
One thing to note is that I would like to have this in v8 as I am also updating the click command. @jemishgopani would you mind creating a backport for v8? You can do that by using
|
Already merged #12383 |
Awesome! Well done and thank you for the contributoon 👍 |
Hey jemishgopani 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Proposed changes
issue #12190
Types of changes
Checklist
Backport Request
//: # (The current
main
branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8
branch.)v9
and doesn't need to be back-ported#XXXXX
Further comments
Reviewers: @webdriverio/project-committers