Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resigningEnabled capability to @wdio/types (#12397) #12398

Merged
merged 2 commits into from Mar 3, 2024

Conversation

AlexRivero
Copy link
Contributor

@AlexRivero AlexRivero commented Mar 3, 2024

Proposed changes

Declared resigningEnabled capability in SauceLabsCapabilities interface, at @wdio/types. Fix for: #12397

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

* Declared resigningEnabled capability in SauceLabsCapabilities interface
Copy link

linux-foundation-easycla bot commented Mar 3, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: christian-bromann / name: Christian Bromann (e2692b3)
  • ✅ login: AlexRivero / name: Alex Rivero Ferràs (b1ee20a)

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot!

packages/wdio-types/src/Capabilities.ts Outdated Show resolved Hide resolved
@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Mar 3, 2024
@christian-bromann christian-bromann merged commit c5f2c29 into webdriverio:main Mar 3, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants