Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CBT for hooks and Skipped tests for hook failures #12454

Merged
merged 1 commit into from Mar 9, 2024

Conversation

sriteja777
Copy link
Contributor

@sriteja777 sriteja777 commented Mar 8, 2024

Proposed changes

  • Fix typos

The bug is only in v8 branch. Rest branches v7 and main don't have this bug, PRs not needed for main and v7

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@karanshah-browserstack
Copy link

@christian-bromann FYI, This is a bug that got introduced into the past release. Looks good from BrowserStack's point of view, is it possible for you to review this and release a new version with the fix?

@erwinheitzman
Copy link
Member

erwinheitzman commented Mar 8, 2024

Hi @sriteja777 can you file the issue so that we can verify the bug before we look into this?

EDIT: just noticed Karanshah's comment, feel free to ignore my comment 👍

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Mar 9, 2024
@christian-bromann christian-bromann merged commit 2d42964 into webdriverio:v8 Mar 9, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants