Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrowserStack Accessibility stability improvements #12482

Merged
merged 5 commits into from Mar 12, 2024

Conversation

07souravkunda
Copy link
Contributor

Proposed changes

This change is to perform a page scan for Browserstack Accessibility before every DOM changing command that is being run as part of a user's test. The commands being wrapped for this purpose belong to the Webdriverio Browser & Element class.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@07souravkunda 07souravkunda changed the title A11 stability v7 BrowserStack Accessibility stability improvements Mar 12, 2024
@amaanbs
Copy link
Contributor

amaanbs commented Mar 12, 2024

Approved internally by Browserstack.

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Mar 12, 2024
@christian-bromann christian-bromann merged commit d5ccecc into webdriverio:v7 Mar 12, 2024
4 of 6 checks passed
@karanshah-browserstack
Copy link

@christian-bromann Any plans on when is the next v7 release scheduled?

@christian-bromann
Copy link
Member

I can try to make a release today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants