Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(wdio-config): add outputDir default #12666

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

(wdio-config): add outputDir default #12666

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a19959
(wdio-config): add outputDir default
erwinheitzman Apr 10, 2024
f5e7170
(wdio-config): add outputDir default
erwinheitzman Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/wdio-config/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const DEFAULT_CONFIGS: () => Omit<Options.Testrunner, 'capabilities'> = (
specs: [],
suites: {},
exclude: [],
outputDir: undefined,
outputDir: '.wdio-artifacts/logs',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should call the directory just wdio and maybe start recommending using this for all WebdriverIO related files, e.g. logs, baselines and config files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea a lot and am thinking about a .wdio directory so that it is clear that this contains configuration files and more.
It also means the files are at the top in your IDE which is useful as you have all you configuration related files in one location (any dot files (directories) will all live at the top). What do you think? 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I would have one request which would be to allow users to store wdio logs to stdout and in stdout at the same time. AFAIK right now users can only decide between either of them and I think it makes sense to allow the scenario to make both possible.

Background: I personally like to have these WebDriver commands prinited in stdout so I can immediately debug them as my test go on and I print stuff in the console. If we set a default outputDir I would need to comment in/out the output dir option.

I think I would be fine if I can disable the outputDir option by just passing in a --no-outputDir but not sure if yargs supports recognises this and overwrites the hard coded property in the config with undefined. Alternatively I can imagine to pass in a --stdout-logging or just --stdout to enable both.

logLevel: 'info' as const,
logLevels: {},
groupLogsByTestSpec: false,
Expand Down