fix: error counts in junit reporter #12715
Conversation
| testCase.failure() | ||
| } | ||
| testCase.failure() |
There was a problem hiding this comment.
I think with this change we would report a failure twice.
There was a problem hiding this comment.
I have removed the extra call. Anyway I have checked the code, it won't report the failure twice.
All tests are passing, but there is some issue with code coverage. This issue is evident with other closed pr's as well - TypeError: Cannot read properties of undefined (reading 'endCol')
There was a problem hiding this comment.
It's an issue with a dependency update we recently made. I am working on getting this fixed, so we can update your branch, which then should pass
There was a problem hiding this comment.
After merging the main branch, the unit tests are passing. But e2e mac tests are failing. Is there anything we can do to help?
|
Two more requests:
Thanks! |
|
@christian-bromann , I have completed the requested items. Please help review once again. |
|
Hey ASaiAnudeep 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Proposed changes
fixes error counts in junit reporter - #12710
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-portedFurther comments
Reviewers: @webdriverio/project-committers