Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resignApp capability type #12845

Merged

Conversation

dprevost-LMI
Copy link
Contributor

@dprevost-LMI dprevost-LMI commented May 8, 2024

Proposed changes

Add resignApp capability type

We need to use this capability, but we stumble into typing issues.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (N/A)

Backport Request

Reviewers: @webdriverio/project-committers

Copy link

linux-foundation-easycla bot commented May 8, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@christian-bromann
Copy link
Member

@dprevost-LMI thanks for the contribution, mind signing the CLA?

@dprevost-LMI
Copy link
Contributor Author

dprevost-LMI commented May 9, 2024

@dprevost-LMI thanks for the contribution, mind signing the CLA?

@christian-bromann, Done! That was a learning path...

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann
Copy link
Member

  • Back-ported PR at #XXXXX (in progress)

The main branch is currently for v9 development if you are interested having this backported to v8, mind raising the same pr for the v8 branch?

@dprevost-LMI
Copy link
Contributor Author

  • Back-ported PR at #XXXXX (in progress)

The main branch is currently for v9 development if you are interested having this backported to v8, mind raising the same pr for the v8 branch?

Will do, I was waiting for the merge to cherry pick the main commit but I can also open a PR with the same commit

@dprevost-LMI
Copy link
Contributor Author

See #12851 (comment) for the v8 PR

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label May 10, 2024
@christian-bromann christian-bromann merged commit ff9b1dd into webdriverio:main May 10, 2024
3 checks passed
@wdio-bot
Copy link
Contributor

Hey dprevost-LMI 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@christian-bromann christian-bromann added the First Contribution 🎉 Highlights PRs of people that made their first contribution to the project label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expensable $15 💸 First Contribution 🎉 Highlights PRs of people that made their first contribution to the project PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants