Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated sinon method in test:unit #2724

Closed
wants to merge 1 commit into from

Conversation

mattc41190
Copy link

Proposed changes

When running the tests I noticed that Sinon was warning about:

sinonjs/sinon#1630

So I switched it

Types of changes

  • [ x] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [x ] I have read the CONTRIBUTING doc
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] I have added necessary documentation (if appropriate)

Further comments

Reviewers: @christian-bromann

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


mcale seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@mattc41190
Copy link
Author

work user -- switching user

@mattc41190 mattc41190 closed this May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants