Add support for find by attribute and content #2965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add support for selecting elements by attribute as well as content.
Before this change it was only possible to select some element by a given tag name, id or class and a certain content, like
div#main*=Hello
.After this change it will be also possible to select by attribute, like
div[data-test-name="main"]*=Hello
Motivation
In our project we are using
data-test-name
attributes for marking elements that will be consumed by our tests. Since we are using styled components which already generate random class names for elements, we avoid polluting the class attribute by using this specific attribute for tests element targeting.Types of changes
Checklist
Further comments
I have taken this as an opportunity for removing some repeated code, so now all the id class or attribute + content cases are handled by a single regular expression.
Reviewers: @webdriverio/technical-committee