Fixes and tests for Protocol.windowHandlePosition #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
christian-bromann
added a commit
that referenced
this pull request
Nov 13, 2014
Fixes and tests for Protocol.windowHandlePosition
|
No problem. Just noticed a minor bug in test. Fix is here - 7b81b2f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Protocol.windowHandlePosition implementation doesn't work in cases when we don't specify tabid (assuming current window).
Examples:
client.windowHandlePosition(function(err, res) {console.log(res.value);
});
expecting: object with x and y cordinates of current window
receiving: TypeError: string is not a function
-client.windowHandlePosition({x: 600, y: 100});expecting: current window movement to cordinates
receiving: nothing happens
Let me know whether something is wrong.