Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix param for getRunnerName #3420

Merged
merged 1 commit into from Jan 25, 2019
Merged

Fix param for getRunnerName #3420

merged 1 commit into from Jan 25, 2019

Conversation

christian-bromann
Copy link
Member

Proposed changes

Set proper param for getRunnerName.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Jan 25, 2019
@christian-bromann christian-bromann merged commit 1e6a093 into master Jan 25, 2019
@christian-bromann christian-bromann deleted the cb-interface-fix branch January 25, 2019 00:48
@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #3420 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3420   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files         131      131           
  Lines        2911     2911           
  Branches      633      633           
=======================================
  Hits         2832     2832           
  Misses         74       74           
  Partials        5        5
Impacted Files Coverage Δ
packages/wdio-cli/src/interface.js 98.05% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d8ae2...c0f02a4. Read the comment docs.

yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Jun 13, 2019
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant