wdio-devtools-service: adding debuggerAddress parameter #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3841 +/- ##
==========================================
+ Coverage 98.43% 98.43% +<.01%
==========================================
Files 150 150
Lines 3442 3446 +4
Branches 749 750 +1
==========================================
+ Hits 3388 3392 +4
Misses 49 49
Partials 5 5
Continue to review full report at Codecov.
|
christian-bromann
requested changes
Apr 11, 2019
BorisOsipov
approved these changes
Apr 12, 2019
abjerstedt
pushed a commit
that referenced
this pull request
Apr 26, 2019
## Proposed changes Fix #3744 . [//]: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.) ## Types of changes [//]: # (What types of changes does your code introduce to WebdriverIO?) [//]: # (_Put an `x` in the boxes that apply_) - [x] Bugfix (non-breaking change which fixes an issue) ## Checklist [//]: # (_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._) - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) ## Further comments I'm not sure that my implementation will work :). 1) Is adding `constructor` will add possibility to add parameter in wdio config like I wrote in `README.md`? 2) Could someone help with tests. I'm not familiar with mocking stuff? [//]: # (If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...) ### Reviewers: @webdriverio/technical-committee
yamkay
pushed a commit
to MoveInc/webdriverio
that referenced
this pull request
Sep 4, 2019
…3841) ## Proposed changes Fix webdriverio#3744 . [//]: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.) ## Types of changes [//]: # (What types of changes does your code introduce to WebdriverIO?) [//]: # (_Put an `x` in the boxes that apply_) - [x] Bugfix (non-breaking change which fixes an issue) ## Checklist [//]: # (_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._) - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) ## Further comments I'm not sure that my implementation will work :). 1) Is adding `constructor` will add possibility to add parameter in wdio config like I wrote in `README.md`? 2) Could someone help with tests. I'm not familiar with mocking stuff? [//]: # (If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...) ### Reviewers: @webdriverio/technical-committee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix #3744 .
Types of changes
Checklist
Further comments
I'm not sure that my implementation will work :).
constructorwill add possibility to add parameter in wdio config like I wrote inREADME.md?Reviewers: @webdriverio/technical-committee