Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wdio-runner: catch getLogTypes error #3870

Merged
merged 1 commit into from Apr 22, 2019
Merged

wdio-runner: catch getLogTypes error #3870

merged 1 commit into from Apr 22, 2019

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented Apr 22, 2019

Proposed changes

wrap getLogTypes with try/catch to fix #3834

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@mgrybyk mgrybyk changed the title wdio-runner: catch logTypes error wdio-runner: catch getLogTypes error Apr 22, 2019
@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #3870 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3870      +/-   ##
==========================================
+ Coverage   98.46%   98.46%   +<.01%     
==========================================
  Files         150      150              
  Lines        3454     3457       +3     
  Branches      754      754              
==========================================
+ Hits         3401     3404       +3     
  Misses         48       48              
  Partials        5        5
Impacted Files Coverage Δ
packages/wdio-runner/src/index.js 97.67% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0fa8a...0cce57c. Read the comment docs.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Apr 22, 2019
@christian-bromann christian-bromann merged commit 2761cde into webdriverio:master Apr 22, 2019
@mgrybyk mgrybyk deleted the fix-get-log-types branch April 23, 2019 15:00
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command not found: Get session log types
2 participants