Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix headless endpoint #3876

Merged
merged 3 commits into from Apr 24, 2019
Merged

Fix headless endpoint #3876

merged 3 commits into from Apr 24, 2019

Conversation

christian-bromann
Copy link
Member

Proposed changes

We now have the final endpoint for Sauce headless, let's update all appearances.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Apr 23, 2019
@christian-bromann christian-bromann requested a review from a team April 23, 2019 21:39
wswebcreation
wswebcreation reviewed Apr 23, 2019
View reviewed changes
Copy link
Member

@wswebcreation wswebcreation left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christian-bromann

Just check-check-double-check, how will this impact the saucelabs module

@codecov
Copy link

codecov bot commented Apr 23, 2019 •
edited

Codecov Report

Merging #3876 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3876      +/-   ##
==========================================
+ Coverage   98.57%   98.59%   +0.02%     
==========================================
  Files         153      153              
  Lines        3434     3484      +50     
  Branches      750      771      +21     
==========================================
+ Hits         3385     3435      +50     
  Misses         44       44              
  Partials        5        5
Impacted Files Coverage Δ
.../wdio-spec-reporter/tests/__fixtures__/testdata.js 100% <ø> (ø) ⬆️
packages/wdio-spec-reporter/src/index.js 100% <ø> (ø) ⬆️
packages/wdio-config/src/utils.js 100% <100%> (ø) ⬆️
packages/webdriver/src/utils.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f3e8e...afbb854. Read the comment docs.

@christian-bromann
Copy link
Member Author

Just check-check-double-check, how will this impact the saucelabs module

This doesn't affect the saucelabs module at all. The saucelabs module has the right configurations: https://github.com/saucelabs/node-saucelabs/blob/master/src/utils.js#L36

wswebcreation
wswebcreation approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit cdb2856 into master Apr 24, 2019
@christian-bromann christian-bromann deleted the headless-fix branch April 24, 2019 04:07
abjerstedt pushed a commit that referenced this pull request Apr 26, 2019
@christian-bromann @abjerstedt
Fix headless endpoint (#3876)
a4a568f 
* fix headless endpoint

* fix unit test

* fix unit test
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
@christian-bromann
Fix headless endpoint (webdriverio#3876)
fed9f0b 
* fix headless endpoint

* fix unit test

* fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wswebcreation wswebcreation wswebcreation approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christian-bromann @wswebcreation