Fix unit tests when contributing on Windows 10 #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3891 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 153 153
Lines 3434 3434
Branches 749 749
=======================================
Hits 3385 3385
Misses 44 44
Partials 5 5Continue to review full report at Codecov.
|
yamkay
pushed a commit
to MoveInc/webdriverio
that referenced
this pull request
Sep 4, 2019
* junit-reporter: updated documentation to reflect current options * junit-reporter: remove console log lines * junit-reporter: allow reporter to work with runner that has multiple suites * junit-report: fix nested and multiple describe blocks * wdio-sauce-service: update unit test * wdio-junit-reporter: add unit test to cover error options * fix unit tests for windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I have changed some unit test expect statements to use regex to account for file system differences, \ vs / and \ vs /. I contribute using a Windows machine and was getting annoyed with a bunch of tests failing. These changes will make the tests agnostic of windows/mac/linux.
Types of changes
Checklist
Reviewers: @webdriverio/technical-committee