Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wdio-sync: bump fibers version to 4 #3898

Merged
merged 1 commit into from Apr 30, 2019

Conversation

baruchvlz
Copy link
Member

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Bumps node-fiber version to 4 for node 12 support. Ref: #3895

Reviewers: @webdriverio/technical-committee

@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #3898 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3898   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files         153      153           
  Lines        3434     3434           
  Branches      749      749           
=======================================
  Hits         3385     3385           
  Misses         44       44           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c52193d...aa17c3e. Read the comment docs.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Internal 🏠 PRs that contain changes internals label Apr 30, 2019
@christian-bromann christian-bromann merged commit 8f57958 into webdriverio:master Apr 30, 2019
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠 PRs that contain changes internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants