Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

wdio-selenium-standalone: fix watch mode #3970

Merged
merged 1 commit into from May 14, 2019

Conversation

fastmx
Copy link
Contributor

@fastmx fastmx commented May 14, 2019

Selenium was exiting after first run. This triggered an error on next attempts.

Proposed changes

Add/fix support for watch mode #3897

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

I'm not sure if there is other way to listen on process exit (so i did it on top level). If you have any suggestion to this bit then i'm open 馃憤

Reviewers: @webdriverio/technical-committee

@fastmx
Copy link
Contributor Author

fastmx commented May 14, 2019

@christian-bromann CLA is signed; new pr because previous changes vanished after force push in wrong time

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #3970 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3970      +/-   ##
==========================================
+ Coverage   98.59%   98.59%   +<.01%     
==========================================
  Files         154      154              
  Lines        3477     3487      +10     
  Branches      763      765       +2     
==========================================
+ Hits         3428     3438      +10     
  Misses         44       44              
  Partials        5        5
Impacted Files Coverage 螖
...s/wdio-selenium-standalone-service/src/launcher.js 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8f1025c...110b307. Read the comment docs.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 thanks!

@christian-bromann christian-bromann added the PR: Bug Fix 馃悰 PRs that contain bug fixes label May 14, 2019
@christian-bromann christian-bromann merged commit 6fd3a43 into webdriverio:master May 14, 2019
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 馃悰 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants