Fix queryAppState protocol

[nextlevelbeard]

Proposed changes

Fixes #3976

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

[jsf-clabot]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #3977 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3977   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files         155      155           
  Lines        3496     3496           
  Branches      767      767           
=======================================
  Hits         3447     3447           
  Misses         44       44           
  Partials        5        5

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c97d37...745586f. Read the comment docs.

[christian-bromann]

Sorry, it seems this in not correct according to the Appium docs: http://appium.io/docs/en/commands/device/app/app-state/

[nextlevelbeard]

@christian-bromann Just noticed but it may be out of date.
A POST method has been added to the JSONWP Specification in appium/appium-base-driver#185.

https://github.com/appium/appium-base-driver/blob/master/lib/protocol/routes.js#L472 .

Could you try to reproduce #3976 ?

[mgrybyk]

According to https://github.com/appium/appium-base-driver/blob/master/lib/protocol/routes.js#L472 both GET and POST methods should be supported. Most likely one of them is outdated and exists for compatibility.

However according to http://appium.io/docs/en/commands/device/app/app-state/ it should be GET, which is not necessarily correct because queryAppState request has payload.

I don't mind changing it from GET to POST if POST works with latest Appium version, which seems to be true.

[nextlevelbeard]

I don't mind changing it from GET to POST if POST works with latest Appium version, which seems to be true.

It seems to be true for me and just to reinforce: this isn't a nitpicking thing like "we should use POST cause I feel like it". By using GET, the queryAppState command is not working for me right now, as I've detailed in #3976. An empty payload is sent instead of the appId/bundleId.

Fix queryAppState protocol (#3977)