Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getWindowSize command #3979

Merged
merged 1 commit into from May 15, 2019
Merged

Add getWindowSize command #3979

merged 1 commit into from May 15, 2019

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented May 15, 2019

Proposed changes

Added getWindowSize to choosing between getWindowSize and getWindowRect commands and be consistent with setWindowSize command.

Fixes #3905

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Affects webdriver package, requires documentation to be updated and update of webdriver, webdriverio and @wdio/sync typings to be generated.

Reviewers: @webdriverio/technical-committee

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #3979 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3979      +/-   ##
==========================================
+ Coverage   98.59%   98.59%   +<.01%     
==========================================
  Files         154      155       +1     
  Lines        3492     3496       +4     
  Branches      766      767       +1     
==========================================
+ Hits         3443     3447       +4     
  Misses         44       44              
  Partials        5        5
Impacted Files Coverage Δ
.../webdriverio/src/commands/browser/getWindowSize.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b961c...48e9aef. Read the comment docs.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ it 👍

@christian-bromann christian-bromann added the PR: Spec Compliancy 👓 PRs that contain changes to the protocol specs label May 15, 2019
@christian-bromann christian-bromann merged commit bbe8f8e into webdriverio:master May 15, 2019
@mgrybyk mgrybyk deleted the getWindowSize branch May 17, 2019 14:30
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Spec Compliancy 👓 PRs that contain changes to the protocol specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confused different drivers need {get,set}WindowSize() vs {get,set}WindowRect()
2 participants