Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings: add automationName desired capability #3988

Merged
merged 1 commit into from May 18, 2019
Merged

typings: add automationName desired capability #3988

merged 1 commit into from May 18, 2019

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented May 17, 2019

Proposed changes

add automationName desired capability

fix #3984

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@mgrybyk mgrybyk added the PR: Docs 📝 PRs that contain changes to the documentation label May 17, 2019
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #3988 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3988   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files         155      155           
  Lines        3496     3496           
  Branches      767      767           
=======================================
  Hits         3447     3447           
  Misses         44       44           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c97d37...ed35266. Read the comment docs.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit ff9b5af into webdriverio:master May 18, 2019
@mgrybyk mgrybyk deleted the add-automation-name branch May 21, 2019 07:36
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automationName missing in DesiredCapabilities type definitions
3 participants