Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wdio-config: include and exclude at capability level #3995

Merged

Conversation

ergbouncex
Copy link
Contributor

Proposed changes

Allowing spec include/exclude at the capability level to filter properly while passing multiple suites of tests. Previously the capability include/exclude only worked if no suites were passed.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixes issue #3925

Reviewers: @webdriverio/technical-committee

@jsf-clabot
Copy link

jsf-clabot commented May 20, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #3995 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3995      +/-   ##
==========================================
+ Coverage   99.04%   99.04%   +<.01%     
==========================================
  Files         157      157              
  Lines        3462     3467       +5     
  Branches      766      768       +2     
==========================================
+ Hits         3429     3434       +5     
  Misses         28       28              
  Partials        5        5
Impacted Files Coverage Δ
packages/wdio-config/src/lib/ConfigParser.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b9342...b2ba42d. Read the comment docs.

Copy link
Member

@mgrybyk mgrybyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Need one more approval for that

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label May 21, 2019
@christian-bromann christian-bromann merged commit 30f74bc into webdriverio:master May 21, 2019
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
* wdio-config: include and exclude at capability level

* wdio-config: include and exclude at capability level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: New Feature 🚀 PRs that contain new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants