Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print error message on test and "before/after all" hooks failure #3996

Merged
merged 1 commit into from
May 21, 2019
Merged

Print error message on test and "before/after all" hooks failure #3996

merged 1 commit into from
May 21, 2019

Conversation

mgrybyk
Copy link
Member

@mgrybyk mgrybyk commented May 20, 2019

Proposed changes

Currently test and before/after all hooks failures are printed in the very end within reporter.

Change: print error immediately, even if there are no or multiple reporters.
This doesn't affect printing errors in reporters anyhow.

dot + spec before each
image

no reporters before all
image

dot regular test failure
image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

After recent changes in logge PR #3589 is no longer valid.
I suppose current PR does something similar.

Reviewers: @webdriverio/technical-committee

@mgrybyk mgrybyk requested a review from WillBrock May 20, 2019 23:39
@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #3996 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3996      +/-   ##
==========================================
+ Coverage   99.04%   99.04%   +<.01%     
==========================================
  Files         157      157              
  Lines        3462     3473      +11     
  Branches      766      772       +6     
==========================================
+ Hits         3429     3440      +11     
  Misses         28       28              
  Partials        5        5
Impacted Files Coverage Δ
packages/wdio-cli/src/interface.js 100% <100%> (ø) ⬆️
packages/wdio-runner/src/reporter.js 100% <100%> (ø) ⬆️
packages/wdio-runner/src/utils.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b9342...e0af88c. Read the comment docs.

Copy link
Member

@WillBrock WillBrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label May 21, 2019
@christian-bromann christian-bromann merged commit 8f08f46 into webdriverio:master May 21, 2019
@mgrybyk mgrybyk deleted the output-error-message-on-failure branch May 21, 2019 07:36
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: New Feature 🚀 PRs that contain new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants