Adjust commands to use React selectors if element has isReactElement flag

[baruchvlz]

Proposed changes

Correctly use react$$ when waiting for React element to exist in DOM.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Checklist

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

Issue: #4442

Reviewers: @webdriverio/technical-committee

[christian-bromann]

Can we add some unit tests for it? Happy to help with these if you want.

[CrispusDH]

Is it worth to cover other isSomething methods?

[baruchvlz]

That's a good point, I'll take a look at how these methods and adjust them if needed.

[baruchvlz]

The only other command I could find using this was isDisplayed. It has been adjusted in a50e10d .

[baruchvlz]

@christian-bromann Will do, I'll ping you on gitter if any questions arise.

[codecov]

Codecov Report

Merging #4454 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4454      +/-   ##
==========================================
+ Coverage   99.12%   99.13%   +<.01%     
==========================================
  Files         188      188              
  Lines        4711     4715       +4     
  Branches     1003     1007       +4     
==========================================
+ Hits         4670     4674       +4     
  Misses         37       37              
  Partials        4        4

Impacted Files	Coverage Δ
...ackages/webdriverio/src/commands/browser/react$.js	100% <100%> (ø)	⬆️
...ckages/webdriverio/src/commands/browser/react$$.js	100% <100%> (ø)	⬆️
packages/webdriverio/src/utils/getElementObject.js	97.82% <100%> (+0.09%)	⬆️
...ges/webdriverio/src/commands/element/isExisting.js	100% <100%> (ø)	⬆️
...es/webdriverio/src/commands/element/isDisplayed.js	100% <100%> (ø)	⬆️
...ckages/webdriverio/src/commands/element/react$$.js	100% <100%> (ø)	⬆️
...ackages/webdriverio/src/commands/element/react$.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e6a17...fa00de8. Read the comment docs.

[christian-bromann]

👍 nice